Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For RuntimeError and breakpoints, use Box<Any + Send> instead of Box<Any>. #1053

Merged
merged 3 commits into from
Dec 10, 2019
Merged

For RuntimeError and breakpoints, use Box<Any + Send> instead of Box<Any>. #1053

merged 3 commits into from
Dec 10, 2019

Conversation

nlewycky
Copy link
Contributor

@nlewycky nlewycky commented Dec 10, 2019 •
edited
Loading

Description

For RuntimeError and breakpoints, use Box<Any + Send> instead of Box<Any>.

Review

  • Add a short description of the the change to the CHANGELOG.md file

Fixes #1049

@nlewycky
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Dec 10, 2019
@bors
Try #1053:
c5b339d
@bors
Copy link
Contributor

bors bot commented Dec 10, 2019

try

Build failed

@nlewycky nlewycky force-pushed the feature/runtime-error-send branch from 449821c to 0a278c5 Compare December 10, 2019 05:00
@nlewycky
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Dec 10, 2019
@bors
Try #1053:
06dc9ee
@bors
Copy link
Contributor

bors bot commented Dec 10, 2019

try

Build succeeded

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 10, 2019

👎 Rejected by too few approved reviews

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 10, 2019
@bors @nlewycky @syrusakbary
Merge #1053
8a13917 
1053: For RuntimeError and breakpoints, use Box<Any + Send> instead of Box<Any>. r=syrusakbary a=nlewycky

# Description
For RuntimeError and breakpoints, use Box<Any + Send> instead of Box\<Any\>.

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file

Fixes #1049 

Co-authored-by: Nick Lewycky <nick@wasmer.io>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
@bors
Copy link
Contributor

bors bot commented Dec 10, 2019

Build succeeded

@bors bors bot merged commit 298adfd into master Dec 10, 2019
@bors bors bot deleted the feature/runtime-error-send branch December 10, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@bjfish bjfish Awaiting requested review from bjfish

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to resume after a panic?
2 participants
@nlewycky @syrusakbary